Conversation
wxtim
force-pushed
the
feat.cylc-review
branch
5 times, most recently
from
befa4f2 to
f35b60c
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
from
f35b60c to
02987a1
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
from
4d05257 to
b781d3c
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
4 times, most recently
from
b528eea to
37dc894
Compare
|
I just had a look at the macOS failures to see I could offer any help........Ooooof. |
wxtim
force-pushed
the
feat.cylc-review
branch
6 times, most recently
from
f4fc283 to
c4b0ae2
Compare
|
Tests will fail until other branches merged - this commit's tests shows that they should pass after those are merged. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ChrisPaulBennett
left a comment
ChrisPaulBennett
left a comment
There was a problem hiding this comment.
Something is not right with the sorting of `last active time`. It appears to be backwards
wxtim
force-pushed
the
feat.cylc-review
branch
from
016d382 to
a8c9dae
Compare
.github/workflows/test.yml
Outdated
| coverage combine --append src/cylc-flow | ||
| coverage combine --append . |
There was a problem hiding this comment.
I think the tests are failing due to the duplicate coverage combine calls (the command fails if there is no data to combine).
|
Now complaining because the src/cylc-uiserver directory does not exist. Not sure the |
|
@wxtim, are cylc-flow changes ( |
| raise cherrypy.HTTPError(404) from None | ||
| f_size = tar_info.size | ||
| handle = tar_f.extractfile(path_in_tar, 'rb') | ||
| handle = tar_f.extractfile(path_in_tar) |
There was a problem hiding this comment.
I can't see how this ever worked.
|
@oliver-sanders ffeb50f has passing tests and coverage associated with it. Coverage only reaches 75%. Will see if I can improve, but might be better as follow up? |
|
We have coverage information for the tests we inherited from the old version, that's all that matters. |
|
@wxtim, are the cylc/release-actions changes required for this in place? If so, lets run CI with the new config to make sure it's working. |
I hadn't expected cylc/cylc-flow#7068 to be merged, so I was merrily pushing changes to it. |
|
Merged: cylc/cylc-flow#7232 Kicking tests... |
|
Tests ran (and passed!), but coverage didn't, likely due to the skip-ci comment! |
…uired for this PR to work
3 participants
Closes cylc/cylc-flow#5937 and cylc/cylc-flow#3441
Requires cylc/cylc-flow#7068 to work correctly (else
cylc reviewis labelled a dead-end).Sort of requires cylc/release-actions#136 To run coverage later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).Test working can be demonstrated by adding this to CI.
https://github.com/cylc/cylc-uiserver/actions/runs/19763672460/job/56631293468
?.?.xbranch.